Re-audit the Modules/imports panel#96
Merged
Merged
Conversation
… artifact Re-ran every entry in the panel one process at a time, the way the gate drives them, to recheck ground truth on the current build. All twelve files plus the three directory suites come back green with no errors and no failures, and the MANIFEST counts already match, so nothing in the port needed changing. While re-running test_zipimport I hit the occasional EOFError out of zipimport's _get_data when I had several copies going at once in the same directory. That turns out to be the suite reusing one fixed archive name in the cwd, so concurrent processes stomp on each other's file. CPython does the same thing under that setup. Run sequentially, one process per entry, it passes every time, so I left the code alone and wrote the finding into the spec.
Owner
Author
|
CI's green across the board (linux/macos/windows test matrices, vet, lint, cfg-phase-parity). Nothing in the panel needed touching, so this is just the re-audit note landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went back over the Modules/imports panel (the 12 flat test files plus the test_import, test_importlib and test_module suites) on the current build to recheck where it actually stands.
I ran each entry the way the gate runs it, one process at a time, and everything comes back clean:
No errors, no failures, and the MANIFEST counts already line up, so there was no port change to make here.
The one thing worth flagging: while re-running test_zipimport with several copies going at once in the same directory I'd occasionally see an EOFError come out of zipimport's _get_data. That's the suite reusing a single fixed archive name in the cwd, so two concurrent processes end up truncating each other's file mid-read. CPython behaves the same way in that setup. Sequentially, one process per entry, it passes every time. I left the code alone and wrote the finding into the spec rather than papering over it.
So this PR is just the re-audit note in spec 1731.