Disable Rod leakless launcher on Windows#54
Merged
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Owner
|
LGTM, thank you for your contribution! Please feel free to close the related issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pool.Closeflow.Fixes #42.
Test plan
/wio test .workflow from this wio: selected the Windows launcher policy as the highest-value regression guard, chose the narrowest unit-level oracle for the platform decision, then validated through the real CLI clone surface.go test ./browser -run TestLauncherLeaklessDisabledOnWindowsgo test ./browsergo test -race -shuffle=on -count=1 ./browsergo build -o D:\tmp\opencode\kage-pr42\kage.exe ./cmd/kageD:\tmp\opencode\kage-pr42\kage.exe clone https://example.com --max-pages 1 --force -o D:\tmp\opencode\kage-pr42\out-final-2succeeded without--control-url; output containedexample.com\index.html.1 -> 1.kage.exe clone --helprenders clone help;kage.exe clone ":bad-url" --max-pages 1 --forcereturns the expected invalid URL error.Full-suite note
go test ./...currently has one Windows failure in unmodifiedpacktests:pack.TestBuildAppDirreportsAppRun is not executableatpack/appdir_test.go:64. All other packages/tests passed (103 passed, 1 failed).