Preserve canvas pixels in rendered clones#55
Open
Valid-Systems wants to merge 2 commits into
Open
Conversation
Owner
|
There are some conflicts with the current |
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
5d89619 to
943e119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toDataURLto avoid worst-case HTML bloatVerification
go test ./browser -run TestRenderPreservesCanvasPixels -count=1rtk go test ./browser -run 'TestRenderPreservesCanvasPixels|TestRenderCapturesFinalDOM|TestRenderRoutesNonHTML' -count=1rtk go test ./browser -count=1rtk go test -race ./browser -count=1rtk go build ./cmd/kagekage clone https://blitzgraph.com/ --control-url <local Chrome DevTools ws> --max-pages 1 --force -o D:\tmp\opencode\kage-blitzgraph\out-canvas-final, then served the clone and inspected it with Playwright:inlineCanvasImages=1,canvasTags=0,scriptTags=0,cloneFailed=0,cloneBadResponses=0Known Windows main-branch failures
rtk go test ./...still fails on Windows inpack.TestBuildAppDir(AppRun is not executable) and clone render tests (fork/exec D:\tmp\leakless-...). The same focused failures reproduce from a cleanmainworktree at105e68f.