Skip to content

feat(ci): add previous review comment handling to code review#4

Merged
xdanger merged 2 commits intomainfrom
xdanger-claude/gifted-meitner
Mar 29, 2026
Merged

feat(ci): add previous review comment handling to code review#4
xdanger merged 2 commits intomainfrom
xdanger-claude/gifted-meitner

Conversation

@xdanger
Copy link
Copy Markdown
Member

@xdanger xdanger commented Mar 29, 2026

Changes

  • Enhanced code review workflow to handle previous review comments from claude[bot]
  • Added logic to check and resolve previously identified issues before creating new comments
  • Implemented thread resolution via GraphQL for marked-as-fixed issues
  • Increased max turns from 5 to 10 to support additional review operations
  • Added detailed instructions for:
    • Fetching previous inline comments
    • Comparing against current diff state
    • Replying to comments based on fix status (Fixed/Persists/Partially Fixed)
    • Resolving comment threads via GraphQL mutations

Impact

Enables the code review bot to better track and manage its own feedback across multiple review cycles, reducing duplicate comments and improving overall review efficiency.

- 🔧 Handle previous claude[bot] inline comments on `synchronize` events
  to avoid duplicate comments on already-fixed issues
- 🔧 Auto-resolve fixed comment threads via GraphQL
- 🔧 Bump `--max-turns` from 5 to 10 for processing previous comments

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reusable Code Review GitHub Actions workflow to let the review agent find, respond to, and resolve its own prior inline review comments before generating new ones, reducing duplicate feedback across review iterations.

Changes:

  • Added prompt instructions for fetching previous inline comments, checking current code, and replying based on fix status.
  • Added GraphQL-based thread resolution guidance for issues marked fixed.
  • Increased the Claude action --max-turns from 5 to 10 to support the additional operations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba82c7268f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- paginate REST comment fetch and exclude reply comments
  (`in_reply_to_id == null`) to avoid reprocessing bot's own replies
- paginate GraphQL thread lookup and fetch all comments per thread
  (`first:100`) for reliable `databaseId` matching
- add `GH_TOKEN` env to `claude-code-action` step so `gh api` calls
  are authenticated

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions bot requested a review from Copilot March 29, 2026 12:17
@xdanger xdanger review requested due to automatic review settings March 29, 2026 12:17
@xdanger xdanger merged commit d247ada into main Mar 29, 2026
3 of 4 checks passed
@xdanger xdanger deleted the xdanger-claude/gifted-meitner branch March 29, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants