proto: support CDC restart #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a new DDL RPC that allows CDC to be restarted on a space. Needed for tarantool/aeon#589
ImeevMA
force-pushed
the
imeevma/gh-589-add-cdc-restart
branch
from
b1a9112 to
6771787
Compare
locker
reviewed
Dec 22, 2025
| rpc DropSpace(DropSpaceRequest) returns (DropSpaceResponse) {} | ||
|
|
||
| // Restart CDC for a space. | ||
| rpc RestartCDC(RestartCDCRequest) returns (RestartCDCResponse) {} |
Member
There was a problem hiding this comment.
We don't need it, actually. We only need the SQL API because this is a command that's supposed to be used by the admin. That's why I mentioned only SQL in the ticket.
locker
reviewed
Dec 22, 2025
| // Drops a space by name. | ||
| rpc DropSpace(DropSpaceRequest) returns (DropSpaceResponse) {} | ||
|
|
||
| // Restart CDC for a space. |
Member
There was a problem hiding this comment.
Unclear what CDC restart does. It'd probably be nice to say a few words about it, as well as about what messages are pushed and when if CDC is enabled for a space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new DDL RPC that allows CDC to be restarted on a space.
Needed for tarantool/aeon#589