WIP: unacceptable TypeScript detection#241
Open
knocte wants to merge 18 commits into
Open
Conversation
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
5c3362c to
dab2e0a
Compare
First "Unacceptable TypeScript" failing test.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
dab2e0a to
c32b666
Compare
First implementation of ContainsUnacceptableTypeScript().
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
9a1b21a to
d14a97f
Compare
Should already pass.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
f6590dc to
ad84fba
Compare
Should be a failing test because the word 'any' is only a substring.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
4a5c559 to
1c1f310
Compare
Using a word boundary in a regex to not flag "anything" or "Many".
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
1c1f310 to
9af2284
Compare
It is a failing test.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
6 times, most recently
from
de92035 to
b99e577
Compare
Unacceptable TypeScript work in progress.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
b99e577 to
faf94f5
Compare
This time a failing test with more than one string.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
6 times, most recently
from
dcdda16 to
f4a91b9
Compare
Unacceptable TypeScript work in progress.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
2 times, most recently
from
def0104 to
49c6c84
Compare
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
2 times, most recently
from
5eee3ec to
a44b661
Compare
TypeScript can have many different chars for strings, not just double quotes; so we add this failing test.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
a44b661 to
1f067b8
Compare
Unacceptable Typescript work in progress.
With comment containing 'any', failing test.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
bef1641 to
ce7dfcc
Compare
Unacceptable TypeScript work in progress.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
2 times, most recently
from
fe4610c to
d7e8c06
Compare
Failing test for /* this kind of comments */, but single-line for now.
Unacceptable TS work in progress.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
2 times, most recently
from
239187f to
3c2a787
Compare
This one should fail the convention. It should be already passing.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
3 times, most recently
from
e4bd06f to
6697459
Compare
With both multi-line strings and multi-line comment, for the upcoming Unacceptable TS script. Should be failing tests.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
2 times, most recently
from
5171d8a to
0f6bc7f
Compare
Unacceptable TypeScript work in progress. NOTE: fsxc had to be upgraded or it would give warnings as errors about .NET6.0 being deprecated...
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
0f6bc7f to
9a8dd6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.