Fix zero-decimal currency formatting#46
Open
troioi-vn wants to merge 1 commit intotastyigniter:4.xfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes formatting for zero-decimal currencies such as VND.
When
decimal_positionis0, the currency format should not include a decimal separator. The previous logic always appended the decimal sign, which could lead to invalid formatting assumptions downstream.Changes
decimal_positionis0Verification
decimal_position = 0Notes
I could not run the full test suite locally because the project test setup expects a DB driver that is not available in my current environment.