Open
Conversation
Add 'quiet_output' to Wtp to not print errors to stdout via _fmt_errmsg()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'quiet_output' to Wtp to not print errors to stdout via _fmt_errmsg()
When parsing a dump the output from errors (
Wtp.error()and the likes) can be quite overwhelming, and not needed when all the errors are accessible viaWtp.to_return()in a parsable data structure. This new option toWtphelps keep the output quiet when it is not needed.I considered using the
quietparameter, but its current use is to quiet the logging. Better not mix things up I suppose.Usage:
(Defaults to False, current behavior)
NB: the error messages sent to stdout cause a problem with unittest for
wiktextractorwhere the parser is run in threads, in which case the stdout of the threads can't be captured by unittest. This PR is an attempt to mitigate that problem without drastic changes to the current behavior of the code.