Skip to content

Dockerify#7

Open
RyanBalfanz wants to merge 9 commits intotdeck:masterfrom
RyanBalfanz:dockerify
Open

Dockerify#7
RyanBalfanz wants to merge 9 commits intotdeck:masterfrom
RyanBalfanz:dockerify

Conversation

@RyanBalfanz
Copy link
Copy Markdown
Collaborator

@RyanBalfanz RyanBalfanz commented Mar 24, 2017

TODOs:

  • Create a data volume for the shelve database.
  • Update README to include Docker info.
  • echo "TEAM_DB_FILE=/var/run/data/teambot.db" >> .env

@tdeck
Copy link
Copy Markdown
Owner

tdeck commented Mar 24, 2017

Thanks for putting this together. Sadly I'm not a docker expert, but a couple of thoughts:

  1. Teambot willl create a file called teams.db that it persists to disc. Will that just work fine, or do you need a data volume?
  2. It would be great to have some a short section in the readme on how to run this with Docker, if there's anything required.

@RyanBalfanz
Copy link
Copy Markdown
Collaborator Author

Sure, I can update the README and also add a new data volume to store the db.

To run it with Docker (which was useful in my local testing for my other two or so PRs):

docker-compose up

@RyanBalfanz
Copy link
Copy Markdown
Collaborator Author

@tdeck Thoughts on this? I just rebased but wanted to check with you before I continue this work.

@tdeck
Copy link
Copy Markdown
Owner

tdeck commented Mar 30, 2017

Yep, looks good in general. I just still have the inline question about that exposed port, and also I wonder what will happen with the team database if people use this configuration. I thought that generally things in a docker container were treated as ephemeral, and you were supposed to separate out the data. But I'm not really a docker user and I assume it depends on your platform.

Copy link
Copy Markdown
Owner

@tdeck tdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to be reviewed?

Comment thread docker-compose.yml Outdated
volumes:
- .:/src
expose:
- "8000"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

@RyanBalfanz
Copy link
Copy Markdown
Collaborator Author

@tdeck Not quite, been swapped here lately. Though I've not forgotten and will plan to make time for this ASAP.

@RyanBalfanz
Copy link
Copy Markdown
Collaborator Author

@tdeck I cannot seem to find your inline comment. But I think I know what you're asking about: No, we probably don't need to expose anything. I just copy pasted that from another docker-based project I'm working on and must've forgotten to remove it. Good catch!

@tdeck
Copy link
Copy Markdown
Owner

tdeck commented Apr 5, 2017

No hurry on my end, just want to make sure I wasn't neglecting anything. Let me know when you want me to take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants