fix: ranking range/#652#660
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adjusts the date range calculations for weekly, monthly, and yearly rankings by adding a one-day offset to the start date, ensuring accurate period coverage. It also modifies the application configuration by removing default values for rate-limiting environment variables. A review comment identifies that removing these defaults could cause the application to fail at startup if the environment variables are not provided, suggesting they be restored for better robustness.
chaeyn
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
GetRankingService: WEEK/MONTH/YEAR 랭킹 조회 시minusWeeks/Months/Years(1)사용으로 BETWEEN 양끝 포함(inclusive) 조건과 맞물려 기간이 하루 초과 조회되던 문제 수정(
.plusDays(1)추가)GetRankingServiceTest: WEEK/MONTH/YEAR startDate 기대값 업데이트, SEASON 테스트 mock을findCurrentSeason()→findSeasonByDate()로 수정관련 이슈
Closes #652 #658
추가 컨텍스트
BETWEEN startDate AND endDate는 양끝 포함이므로, 예를 들어 WEEK의 경우today.minusWeeks(1)사용 시 실제로 8일치가 조회됨..plusDays(1)로 정확히 7일 범위로 조정season.startDate()를 그대로 사용하므로 해당 없음