feat: product bgm/#662#666
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new product category, BGM, and adds an audio field to the product entity across the database, domain, and API layers. The changes include updating the JPA entity, DTOs, mappers, and API documentation to support background music items. Review feedback suggests enforcing data integrity by ensuring the audio field is only populated for the BGM category, increasing the database column length for audio URLs to prevent truncation, and refining test cases to use realistic data for BGM products.
Finefinee
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
ProductCategory에 BGM 추가
Product 엔티티에 audio 필드 추가 (오디오 파일 URL, nullable)
상품 생성/수정 API 요청에 audio 필드 추가
EquippedItemsData 및 관련 DTO에 bgm 장착 아이템 필드 추가
EquippedItemsAssembler에서 BGM 카테고리 처리 추가
products 테이블 audio 컬럼 추가 및 user_equipped_items check constraint에 BGM 추가
관련 이슈
Closes #662
추가 컨텍스트
BGM은 기존 INSIGNIA / NAMEPLATE / BANNER와 달리 오디오 파일 URL(audio)이 별도로 필요해 Product 전 레이어에 걸쳐 필드를 추가했습니다.
audio 필드는 BGM 전용이며 다른 카테고리에서는 null로 내려갑니다. equippedItems.bgm은 랭킹, 프로필, 라이벌 등 기존에 장착 아이템을 반환하던 모든 API에 자동으로 포함됩니다.