feat: other user profile/#663#668
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a profile privacy feature by adding an "isPrivate" flag to the user entity and database. It introduces new API endpoints for retrieving user profiles, items, GitHub activity, and rivals, with logic to enforce privacy settings. The review feedback identifies opportunities to remove redundant soft-delete checks already handled by repository restrictions, improve timezone consistency for better testability, and refine rival retrieval logic to handle missing data more gracefully.
redjungi09
force-pushed
the
feat/other-user-profile/#663
branch
from
e65f8c6 to
23b9999
Compare
redjungi09
force-pushed
the
feat/other-user-profile/#663
branch
from
23b9999 to
c6f2de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
GET /api/users/{userId})GET /api/users/{userId}/items)GET /api/users/{userId}/github?period=)GET /api/users/{userId}/rivals)PATCH /api/users/me/privacy)users테이블에is_private컬럼 추가관련 이슈
Closes #663
추가 컨텍스트
기본 프로필(
GET /api/users/{userId})은 비공개 여부와 관계없이 항상 공개됩니다. 아이템, GitHub, 라이벌 조회는 비공개 유저일 경우 403을 반환합니다.EquippedItemsDto에insigma필드를@Deprecated+@JsonProperty로 함께 반환하도록 처리했습니다. 기존 클라이언트가insigma를 사용 중이므로, 클라이언트 업데이트 완료 후 제거 예정입니다.GetUserProfileService클래스명이 기존mainpage패키지의 동명 클래스와 충돌하여GetOtherUserProfileService로 변경했습니다.