Skip to content

fix: analyze my exp/#670#671

Merged
redjungi09 merged 2 commits into
developfrom
fix/analyze-my-exp/#670
Apr 12, 2026
Merged

fix: analyze my exp/#670#671
redjungi09 merged 2 commits into
developfrom
fix/analyze-my-exp/#670

Conversation

@hjbin-25

Copy link
Copy Markdown
Member

변경사항

  • EXP/GitHub 기간별 통계 집계 함수 AVG → SUM 으로 수정
    • UserExpHistoryJpaRepository: findDailyDataByUserIds, findWeeklyDataByUserIds, findMonthlyDataByUserIds
    • GitHubDailyStatsJpaRepository: findWeeklyContributionsByUserIds, findMonthlyContributionsByUserIds

관련 이슈

Closes #670

추가 컨텍스트

user_exp_history는 동일 날짜에 acting_category별로 여러 행이 존재하므로,
AVG 집계 시 카테고리 수만큼 나눠진 값이 반환되어 실제 값의 절반이 표시되는 버그 발생.
SUM으로 변경하여 기간 내 실제 총 획득 exp/기여도를 반환하도록 수정.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the aggregation logic in GitHubDailyStatsJpaRepository and UserExpHistoryJpaRepository, replacing AVG with SUM to calculate total points and experience. A review comment suggests adding a filter to exclude 'SEASON_RESET' entries in the experience history queries to ensure the statistics accurately represent user activity and remain consistent with other repository methods.

@redjungi09 redjungi09 merged commit f760bb1 into develop Apr 12, 2026
1 check passed
@hjbin-25 hjbin-25 deleted the fix/analyze-my-exp/#670 branch April 12, 2026 17:40
@Finefinee Finefinee added the bug 기능이 정상적으로 작동하지 않음 label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 기능이 정상적으로 작동하지 않음

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants