feat: monitoring app add/#677#678
Merged
Merged
Conversation
hjbin-25
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request expands the list of monitored applications by adding BLENDER, DATAGRIP, NOTION, FIGMA, and ROBLOX_STUDIO to the MonitoredApp enum, updating the corresponding database CHECK constraints across four tables, and adjusting the service tests. Feedback suggests replacing the redundant CHECK constraints with a dedicated reference table and foreign keys for better maintainability. Additionally, it is recommended to update the test to verify all MonitoredApp values using MonitoredApp.values() instead of manually listing them to ensure the test remains robust as the enum grows.
Comment on lines
+8
to
+26
| OR app_id IN ( | ||
| 'VSCODE', | ||
| 'WEBSTORM', | ||
| 'INTELLIJ_IDEA', | ||
| 'PYCHARM', | ||
| 'GOLAND', | ||
| 'PHPSTORM', | ||
| 'RUBYMINE', | ||
| 'CLION', | ||
| 'RIDER', | ||
| 'ANDROID_STUDIO', | ||
| 'XCODE', | ||
| 'UNITY', | ||
| 'BLENDER', | ||
| 'DATAGRIP', | ||
| 'NOTION', | ||
| 'FIGMA', | ||
| 'ROBLOX_STUDIO' | ||
| ) |
Contributor
Comment on lines
+24
to
+33
| assertThat(result.apps()).contains( | ||
| MonitoredApp.VSCODE, | ||
| MonitoredApp.INTELLIJ_IDEA, | ||
| MonitoredApp.XCODE, | ||
| MonitoredApp.BLENDER, | ||
| MonitoredApp.DATAGRIP, | ||
| MonitoredApp.NOTION, | ||
| MonitoredApp.FIGMA, | ||
| MonitoredApp.ROBLOX_STUDIO | ||
| ); |
Contributor
There was a problem hiding this comment.
redjungi09
approved these changes
Apr 14, 2026
chaeyn
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
경고: 이 기능을 개발한 사람은 모니터링 앱의 작동 방식을 모릅니다.
변경사항
관련 이슈
Closes #
추가 컨텍스트