feat: global notice socket/#681#683
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a real-time notification system for announcement changes by introducing the AnnouncementRefetchNotifier and updating the broadcast infrastructure to support global events. Admin services for announcements now trigger these notifications upon data changes. A critical bug was found where the ChangeDomain.ANNOUNCEMENT constant is missing from its enum definition, which will cause a compilation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
ChangeDomain.ANNOUNCEMENT추가BroadcastRefetchPort.broadcastRefetchToAll()및RefetchEventPublisher.publishToAll()추가관련 이슈
Closes #681
추가 컨텍스트
기존 소켓 브로드캐스트는 특정 유저 ID 목록 대상이었으나, 전체공지는 불특정 다수에게 전송해야 하므로
socketIOServer.getBroadcastOperations()를 활용한 전체 브로드캐스트 경로를 별도로 추가함