Skip to content

refactor: 배틀 시작일 기준 내림차순 하여 정렬#696

Merged
hjbin-25 merged 2 commits into
developfrom
refactor/battle-list-order/#695
Apr 18, 2026
Merged

refactor: 배틀 시작일 기준 내림차순 하여 정렬#696
hjbin-25 merged 2 commits into
developfrom
refactor/battle-list-order/#695

Conversation

@hjbin-25

Copy link
Copy Markdown
Member

변경사항

  • 배틀을 시작일 기준 내림차순 정렬하여서 반환

관련 이슈

Closes #695

추가 컨텍스트

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds descending order sorting by the started_at timestamp to battle repository queries. Feedback was provided regarding the findPendingBattlesByUserId method, noting that pending battles have a null started_at value and should instead be sorted by created_at to reflect the application sequence accurately.

@hjbin-25 hjbin-25 merged commit bf9a41b into develop Apr 18, 2026
@hjbin-25 hjbin-25 deleted the refactor/battle-list-order/#695 branch April 18, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant