fix: protect-admin-api#697
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the security configuration to include the /api/v2/admin/** path under the ADMIN role requirement. A review comment suggests using a more generic wildcard pattern, such as /api//admin/, to ensure all future versioned admin APIs are automatically covered and to simplify maintenance.
| .requestMatchers("/api/config/public").permitAll() | ||
| .requestMatchers("/auth-login.html", "/auth-signup.html").permitAll() | ||
| .requestMatchers("/admin/**", "/api/admin/**").hasRole("ADMIN") | ||
| .requestMatchers("/admin/**", "/api/admin/**", "/api/v2/admin/**").hasRole("ADMIN") |
Contributor
There was a problem hiding this comment.
현재 /api/v2/admin/** 경로를 수동으로 추가하여 보안 취약점을 해결하셨습니다. 하지만 이러한 방식은 향후 /api/v3/admin/**와 같이 새로운 버전의 API가 추가될 때 다시 보안 설정이 누락될 위험이 있습니다. 관리자 API의 경로 패턴이 일정한 규칙(예: /api/{version}/admin/**)을 따른다면, /api/**/admin/**와 같은 와일드카드 패턴을 사용하여 모든 버전의 관리자 API를 일관되게 보호하고 유지보수성을 높이는 것을 권장합니다.
Suggested change
| .requestMatchers("/admin/**", "/api/admin/**", "/api/v2/admin/**").hasRole("ADMIN") | |
| .requestMatchers("/admin/**", "/api/**/admin/**").hasRole("ADMIN") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항