fix: redis scheduler stability/#698#699
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures a scheduling thread pool size and reduces Redis connection and operation timeouts to 3 seconds. The review feedback suggests adding a maximum wait time for the Redis connection pool to prevent infinite thread waiting, ensuring manual Redis client configurations in the Java code also reflect these timeout changes, and adding a thread name prefix to the task scheduler to improve log readability.
Comment on lines
+64
to
+65
| connect-timeout: 3s | ||
| timeout: 3s |
Contributor
There was a problem hiding this comment.
Redis 안정성을 위해 타임아웃을 단축한 것은 좋은 방향입니다. 다만, 시스템 안정성을 위해 다음 두 가지 사항을 추가로 검토해 주세요:
- Lettuce 커넥션 풀 대기 시간 설정: 현재
max-wait설정이 없어 커넥션 풀 고갈 시 스레드가 무한정 대기할 수 있습니다.spring.data.redis.lettuce.pool.max-wait: 3s설정을 추가하는 것을 권장합니다. - 수동 설정 빈 확인:
RedisConfig.java에서 직접 생성하는bucket4jRedisClient빈은 이 설정을 상속받지 않으므로, 해당 빈 설정에도 명시적인 타임아웃 적용이 필요합니다.
Comment on lines
+5
to
+8
| task: | ||
| scheduling: | ||
| pool: | ||
| size: 10 # 각 스케줄러가 독립 스레드 사용 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
관련 이슈
Closes #698
추가 컨텍스트