feat: not available purchase itmes/#706#707
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new field, isAblePurchase, to the product entity across all layers, including the database schema, JPA entities, domain models, and DTOs. This field allows administrators to control whether a product is currently available for purchase, and the CreatePurchaseService has been updated to enforce this restriction by throwing a new NotAblePurchaseException when applicable. The review feedback suggests renaming the field to isPurchasable for better grammatical clarity and switching from the Boolean wrapper class to the primitive boolean type to improve type safety and prevent potential NullPointerException issues during unboxing.
daehyeong2
requested changes
May 6, 2026
redjungi09
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
관련 이슈
Closes #706
추가 컨텍스트
현재 남아있는 데이터와 충돌 여부만 확인해주세요