Skip to content

feat: not available purchase itmes/#706#707

Merged
redjungi09 merged 5 commits into
developfrom
feat/not-available-purchase-itmes/#706
May 6, 2026
Merged

feat: not available purchase itmes/#706#707
redjungi09 merged 5 commits into
developfrom
feat/not-available-purchase-itmes/#706

Conversation

@hjbin-25

@hjbin-25 hjbin-25 commented May 6, 2026

Copy link
Copy Markdown
Member

변경사항

  • 구매 불가능한 아이템 기능 추가
  • 현재 존재하는 아이템을 isAblePurchase = true로 설정
  • 관련 테스트 로직 수정

관련 이슈

Closes #706

추가 컨텍스트

현재 남아있는 데이터와 충돌 여부만 확인해주세요

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new field, isAblePurchase, to the product entity across all layers, including the database schema, JPA entities, domain models, and DTOs. This field allows administrators to control whether a product is currently available for purchase, and the CreatePurchaseService has been updated to enforce this restriction by throwing a new NotAblePurchaseException when applicable. The review feedback suggests renaming the field to isPurchasable for better grammatical clarity and switching from the Boolean wrapper class to the primitive boolean type to improve type safety and prevent potential NullPointerException issues during unboxing.

@redjungi09 redjungi09 merged commit 31ea1b3 into develop May 6, 2026
1 check passed
@hjbin-25 hjbin-25 deleted the feat/not-available-purchase-itmes/#706 branch May 6, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants