Skip to content

merge: develop#710

Merged
Finefinee merged 1 commit into
mainfrom
develop
May 26, 2026
Merged

merge: develop#710
Finefinee merged 1 commit into
mainfrom
develop

Conversation

@Finefinee

Copy link
Copy Markdown
Member

변경사항

관련 이슈

Closes #

추가 컨텍스트

@Finefinee Finefinee added the merge main 병합 label May 26, 2026
@Finefinee Finefinee merged commit d75c641 into main May 26, 2026
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restricts access to the /actuator/** endpoints by requiring the ADMIN role instead of permitting all requests. The reviewer recommends using hasAnyRole("ADMIN", "MONITORING") to ensure external monitoring systems can still access necessary endpoints without requiring full administrative privileges.

.requestMatchers("/admin/**", "/api/admin/**", "/api/v2/admin/**").hasRole("ADMIN")
.requestMatchers("/swagger-ui/**", "/v3/api-docs/**", "/api-docs/**", "/swagger-ui.html").permitAll()
.requestMatchers("/actuator/**").permitAll()
.requestMatchers("/actuator/**").hasRole("ADMIN")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

현재 /actuator/** 경로에 대해 ADMIN 권한을 요구하도록 변경하여 민감한 엔드포인트(예: /actuator/env, /actuator/heapdump 등)를 보호하는 것은 좋은 보안 조치입니다.

다만, Prometheus 등 외부 모니터링 시스템이 /actuator/prometheus/actuator/info와 같은 엔드포인트를 주기적으로 수집(Scraping)해야 하는 경우, 모니터링 시스템에 과도한 권한(ADMIN)을 부여해야 하거나 수집이 차단될 수 있습니다.

권장 사항:
최소 권한 원칙(Principle of Least Privilege)을 준수하기 위해, 모니터링 전용 역할(예: MONITORING)을 추가로 정의하고 hasAnyRole을 사용하여 권한을 부여하는 것을 고려해 보세요.

(참고: /actuator/healthhealthSecurityFilterChain에서 이미 permitAll()로 설정되어 있으므로 이 변경의 영향을 받지 않습니다.)

Suggested change
.requestMatchers("/actuator/**").hasRole("ADMIN")
.requestMatchers("/actuator/**").hasAnyRole("ADMIN", "MONITORING")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge main 병합

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant