Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more of a discussion PR, than something that should actually be merged.
I wanted to go towards enabling astigmatism determination, using a test-set of images that David Mastronade provided to me as examples for difficult cases where CTFFIND failed, but ctfplotter succeeded. The first 4 should have almost no astigmatism, while the last three have roughly 0.4um astigmatism.
No work on astigmatism yet, but I've been thinking about ways the individual functions can return actual+diagnostic data in the form of pydantic models, which then allow plotting methods to make diagnostic plots
https://github.com/teamtomo/torch-ctf-estimation/blob/plotting/docs/test_astigmatism.ipynb
Something to discuss on Wed. if that is the direction we want to use.