fix: remove stale submodule references from Dockerfile, README, AGENTS#3
Merged
YASoftwareDev merged 1 commit intomainfrom Apr 1, 2026
Merged
fix: remove stale submodule references from Dockerfile, README, AGENTS#3YASoftwareDev merged 1 commit intomainfrom
YASoftwareDev merged 1 commit intomainfrom
Conversation
The Dockerfile was broken after the submodule removal: it tried to COPY submodules/asr-api-python and pip install it from a local path. Now it simply runs `pip install .` which fetches techmo-asr-api from GitHub via the VCS dependency declared in pyproject.toml. Also remove the "Manual submodule update" section from README.md and update AGENTS.md to reflect the new install workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2: the submodule removal left three files with broken references.
COPY-ingsubmodules/asr-api-python(no longer exists) and installing it withpip install ./submodules/asr-api-python. Now just runspip install .—techmo-asr-apiis fetched from GitHub automatically via the VCS dep inpyproject.toml. Also removed the stale.gitmodulesand.gitcopies.Test plan
docker buildsucceeds on a fresh clone (no submodule directory present)asr-client --helpworks inside the built image