[codex] 簡単設定のAI/音声プロバイダー設定を改善#533
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesAIモデル定数・依存パッケージ更新
QuickStart型安全化・UIコンポーネント拡張
E2Eテストの更新
Sequence Diagram(s)sequenceDiagram
participant User
participant QuickStart
participant settingsStore
participant getServiceConfigByKey
participant ApiKeyInput
participant renderQuickAIServiceSettings
participant renderQuickVoiceSettings
User->>QuickStart: AIサービスをListboxで選択
QuickStart->>getServiceConfigByKey: selectAIServiceでserviceConfig取得
getServiceConfigByKey-->>QuickStart: serviceConfig（ラベル/プレースホルダ/リンク等）
QuickStart->>ApiKeyInput: serviceConfigが存在する場合のみ表示
QuickStart->>renderQuickAIServiceSettings: サービス別追加設定UI生成（Azure/Dify/LocalLLM等）
renderQuickAIServiceSettings->>settingsStore: エンドポイント/URLモデルID更新
User->>QuickStart: 音声エンジンをselectで選択
QuickStart->>renderQuickVoiceSettings: エンジン別設定UI生成（話者/スタイル/モデル/APIキー等）
renderQuickVoiceSettings->>settingsStore: 話者/スタイル/モデルID等更新
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/features/constants/aiModels.ts (1)
234-355: 🎯 Functional Correctness | 🔴 Criticalclaude-fable-5は2026年6月12日に利用停止されており、削除する必要があります
検証結果により、ほとんどのモデル名は有効であることが確認されました：
claude-opus-4-8、claude-sonnet-4-6、claude-haiku-4-5：有効でアクティブgemini-3.5-flash：2026年5月19日にGA公開、有効でアクティブただし、
claude-fable-5は重大な問題があります：
- Anthropic公式によると、2026年6月9日にリリースされましたが、6月12日にUS輸出規制に関連する指令によりアクセスが停止されました
- 現在（6月23日時点）も利用不可のままです
- このモデルを
modelDefinitionsに含めると、実行時にAPI呼び出しが失敗します
claude-fable-5をmodelDefinitionsから削除してください。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/features/constants/aiModels.ts` around lines 234 - 355, Remove the claude-fable-5 model entry from the anthropic array in the aiModels.ts file. The claude-fable-5 model was discontinued on June 12, 2026 due to US export control restrictions and is no longer available, which means API calls to this model will fail at runtime. Delete the entire object containing the name 'claude-fable-5' property and its associated configuration (multiModal, reasoningEfforts, reasoningTokenBudget) from the anthropic models array.
🧹 Nitpick comments (1)
src/components/settings/quickStart.tsx (1)
811-831: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
ServiceLogoへのas anyを避けてください。AI サービス追加時のロゴ定義漏れを型で検知できなくなります。
aiServiceOptionsとServiceLogoの props を共通のサービス型でそろえ、キャストなしで渡せる状態にしてください。局所修正例
- <ServiceLogo service={modelState.selectAIService as any} /> + <ServiceLogo service={modelState.selectAIService as AIService} /> ... - <ServiceLogo service={option.value as any} /> + <ServiceLogo service={option.value as AIService} />As per coding guidelines,
src/**/*.{ts,tsx}: Use TypeScript strict mode for type safety.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/settings/quickStart.tsx` around lines 811 - 831, The ServiceLogo component is receiving as any casts for the service prop in two places (modelState.selectAIService and option.value), which bypasses TypeScript type checking and prevents detection of missing logo definitions when adding new AI services. Ensure that both modelState.selectAIService and the values in aiServiceOptions are properly typed to match the expected service type of the ServiceLogo component, then remove both as any casts so the types align without explicit casting.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locales/ja/translation.json`:
- Around line 249-253: The description strings
QuickStartAIConversationDescription and QuickStartVoiceDescription do not
accurately reflect all required configuration inputs. Update
QuickStartAIConversationDescription to include mention of URLs and endpoints
that are required depending on the AI service selected (Azure/Dify/Local/Custom
API), not just API key and model. Similarly, update QuickStartVoiceDescription
to include additional required settings such as model UUID and style alongside
API key and speaker selection.
In `@src/components/settings/quickStart.tsx`:
- Around line 33-39: The className constants inputClassName,
selectButtonClassName, and choiceControlClassName use hardcoded Tailwind color
values like bg-white, border-gray-300, and ring-primary/20 that do not respect
the darkMode: class theme switching configuration. Replace these fixed color
classes with CSS variable-based Tailwind tokens from your existing theme
configuration that support both light and dark modes. Ensure all background
colors, border colors, and ring colors use the theme-aware tokens instead of
hardcoded Tailwind color values to maintain consistent styling across theme
switches.
- Around line 118-120: The fetch call for '/speakers_aivis.json' does not
validate the HTTP status code or verify that the response data is actually an
array before passing it to setAivisSpeakers. If the fetch fails or returns a
non-array response (such as an error JSON object), the downstream
aivisSpeakers.map(...) call will crash. Add a check for response.ok after the
fetch call, and validate that the parsed data is an array using Array.isArray()
before calling setAivisSpeakers. Handle error cases appropriately by logging or
setting an empty array as a fallback.
- Around line 15-26: Replace all relative imports in the quickStart.tsx file
with the `@/`* path alias pattern to align with the repository's import
conventions. Convert the imports from './modelProvider/ModelSelector',
'./modelProvider/ApiKeyInput', './modelProvider/ServiceLogo',
'./modelProvider/utils/aiServiceConfigs',
'./modelProvider/hooks/useAIServiceHandlers',
'./modelProvider/hooks/useModelProviderState', '../toggleSwitch', and
'../speakers.json' to use absolute paths starting with `@/components` instead of
relative paths.
- Around line 532-537: The onChange handler for the aivisCloudStyleId input
field is directly converting the input value to a number without validation,
which allows NaN to be saved to the state when users enter invalid or empty
values during editing. Fix this by adding validation to check if the converted
number is valid (not NaN) before updating the settings state in the
settingsStore.setState call, or implement a conditional check that only updates
when a valid number is provided.
---
Outside diff comments:
In `@src/features/constants/aiModels.ts`:
- Around line 234-355: Remove the claude-fable-5 model entry from the anthropic
array in the aiModels.ts file. The claude-fable-5 model was discontinued on June
12, 2026 due to US export control restrictions and is no longer available, which
means API calls to this model will fail at runtime. Delete the entire object
containing the name 'claude-fable-5' property and its associated configuration
(multiModal, reasoningEfforts, reasoningTokenBudget) from the anthropic models
array.
---
Nitpick comments:
In `@src/components/settings/quickStart.tsx`:
- Around line 811-831: The ServiceLogo component is receiving as any casts for
the service prop in two places (modelState.selectAIService and option.value),
which bypasses TypeScript type checking and prevents detection of missing logo
definitions when adding new AI services. Ensure that both
modelState.selectAIService and the values in aiServiceOptions are properly typed
to match the expected service type of the ServiceLogo component, then remove
both as any casts so the types align without explicit casting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 31a4fca1-5391-4a78-9fca-a76d37a7e960
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
locales/ja/translation.jsonpackage.jsonsrc/__tests__/features/constants/aiModels.test.tssrc/components/settings/quickStart.tsxsrc/features/constants/aiModels.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
gpt-5.4-miniに変更しました。背景
簡単設定でAPIキーや話者、モデルUUIDなどの必須級項目が入力できないプロバイダーがあり、選択欄の見た目も詳細設定画面と揃っていませんでした。簡単設定だけで初期セットアップに必要な最低限の項目を埋められるようにしています。
検証
npx eslint src/components/settings/quickStart.tsx src/features/constants/aiModels.ts src/__tests__/features/constants/aiModels.test.tsnpm test -- --runTestsByPath src/__tests__/features/constants/aiModels.test.ts src/__tests__/features/constants/aiModels.reasoning.test.tsnpm run buildSummary by CodeRabbit
リリースノート