Conversation
danielcompton
approved these changes
Aug 30, 2020
Member
danielcompton
left a comment
danielcompton
left a comment
There was a problem hiding this comment.
LGTM.
As a side note, https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame explains how you can ignore this commit in the future for git blame.
| @@ -0,0 +1,58 @@ | |||
| # Vimari Setup | |||
Member
There was a problem hiding this comment.
I would call this file DEVELOPERS.md
Collaborator
Author
|
Some more detail about the linting & formatting setup should be included, I came by this readme which is a bit more specific about setup. Will try to include something similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve the workflow for contributors this PR introduces both linting and formatting of code to the repo. The tools used are explained in
SETUP_README.mdwhich I plan to expand upon with more setup instructions.Two Github workflows have been added that only run on relevant pull requests for linting and formatting either JavaScript code or Swift code.
Lots of changes have been made to make the current code adhere to the default styles enforces by the chosen tools (see #179). I suggest we squash all the commits during the merging process.