Updating TLS samples to use Elasticsearch and reference temporal cli#149
Closed
stuart-wells wants to merge 2 commits intomainfrom
Closed
Updating TLS samples to use Elasticsearch and reference temporal cli#149stuart-wells wants to merge 2 commits intomainfrom
stuart-wells wants to merge 2 commits intomainfrom
Conversation
|
|
stuart-wells
force-pushed
the
stuartwells/tlscleanup
branch
from
f74969f to
d95b6f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Readme update, adding Elasticsearch to the docker-compose for tls-full, updating tls-simple to use elasticsearch 7.17.27
Why?
Current tls-full sample did not run as-is. Took this opportunity to add references to Temporal CLI over tctl
Checklist
Ran steps from README to validate the changes were working again.