Skip to content

Fix type mismatch in Environment::start() $rrCommand parameter #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmortlock wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix type mismatch in Environment::start() $rrCommand parameter #725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5746636
Fix type mismatch in Environment::start() $rrCommand parameter
jmortlock Mar 10, 2026
f2c8d5c
Merge branch 'master' into fix/start-rr-command-type-mismatch
xepozz Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/src/Environment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public static function create(?Command $command = null): self
/**
* @param array<string, mixed> $envs
*/
public function start(?array $rrCommand = null, int $commandTimeout = 10, array $envs = [], string $roadRunnerConfigFile = '.rr.yaml'): void
public function start(?string $rrCommand = null, int $commandTimeout = 10, array $envs = [], string $roadRunnerConfigFile = '.rr.yaml'): void
{
$this->startTemporalTestServer($commandTimeout);
$this->startRoadRunner($rrCommand, $commandTimeout, $envs, $roadRunnerConfigFile);
Expand Down
Loading