Skip to content

feat: update dependency constraint for google/protobuf to support newer version #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xepozz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: update dependency constraint for google/protobuf to support newer version #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b24c0d9
feat: update dependency constraint for google/protobuf to support new…
xepozz Mar 23, 2026
207deaf
chore: replace `Google\Protobuf\Internal\RepeatedField` with `Google\…
xepozz Mar 23, 2026
18b31d8
Merge branch 'master' into feature/protobuf-v5
xepozz Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"ext-curl": "*",
"ext-json": "*",
"google/common-protos": "^4.9",
"google/protobuf": "^4.31.1",
"google/protobuf": "^4.31.1 || ^5.34.0",
"grpc/grpc": "^1.57",
"internal/destroy": "^1.0",
"internal/promise": "^3.4",
Expand Down
5 changes: 0 additions & 5 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,6 @@
<code><![CDATA[getID]]></code>
</PossiblyNullReference>
</file>
<file src="src/Exception/Client/MultyOperation/OperationStatus.php">
<InvalidArgument>
<code><![CDATA[$message->getDetails()]]></code>
</InvalidArgument>
</file>
<file src="src/Exception/Client/ServiceClientException.php">
<ImplementedReturnTypeMismatch>
<code><![CDATA[RepeatedField]]></code>
Expand Down
5 changes: 0 additions & 5 deletions psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,5 @@
<issueHandlers>
<MissingOverrideAttribute errorLevel="suppress" />
<ClassMustBeFinal errorLevel="suppress" />
<DeprecatedClass>
<errorLevel type="suppress">
<referencedClass name="Google\Protobuf\Internal\RepeatedField" />
</errorLevel>
</DeprecatedClass>
</issueHandlers>
</psalm>
2 changes: 1 addition & 1 deletion src/Exception/Client/MultyOperation/OperationStatus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Temporal\Exception\Client\MultyOperation;

use Google\Protobuf\Any;
use Google\Protobuf\Internal\RepeatedField;
use Google\Protobuf\RepeatedField;
use Temporal\Api\Errordetails\V1\MultiOperationExecutionFailure\OperationStatus as OperationStatusMessage;
use Temporal\Exception\Client\UnpackDetailsTrait;

Expand Down
2 changes: 1 addition & 1 deletion src/Exception/Client/UnpackDetailsTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Temporal\Exception\Client;

use Google\Protobuf\Any;
use Google\Protobuf\Internal\RepeatedField;
use Google\Protobuf\RepeatedField;
use GPBMetadata\Temporal\Api\Errordetails\V1\Message;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Internal/Marshaller/ProtoToArrayConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Google\Protobuf\Internal\MapField;
use Google\Protobuf\Internal\Message;
use Google\Protobuf\Internal\OneofField;
use Google\Protobuf\Internal\RepeatedField;
use Google\Protobuf\RepeatedField;
use Google\Protobuf\Timestamp;
use Temporal\Api\Common\V1\Header;
use Temporal\Api\Common\V1\Memo;
Expand Down
Loading