Skip to content

refactor(Request): update ID generation logic and visibility #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roxblnfk wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −6
Open

refactor(Request): update ID generation logic and visibility #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70dd264
refactor(Request): update ID generation logic and visibility
roxblnfk Mar 25, 2026
8582980
refactor(Request): Just use microtime for start id
roxblnfk Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Worker/Transport/Command/Client/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
use Temporal\Worker\Transport\Command\Common\RequestTrait;
use Temporal\Worker\Transport\Command\RequestInterface;

\define(['REQUEST_START_ID'][0], (int) (\microtime(true) * 1_000_000.0));

/**
* Carries request to perform host action with payloads and failure as context. Can be cancelled if allows
*
Expand All @@ -27,7 +29,7 @@ class Request implements RequestInterface
{
use RequestTrait;

protected static int $lastID = 9000;
protected static int $lastID = REQUEST_START_ID;
protected int $id;
protected ValuesInterface $payloads;
protected HeaderInterface $header;
Expand Down Expand Up @@ -65,12 +67,12 @@ public function getFailure(): ?\Throwable

private function getNextID(): int
{
$next = ++static::$lastID;
++static::$lastID;

if ($next >= \PHP_INT_MAX) {
$next = static::$lastID = 1;
if (static::$lastID === \PHP_INT_MAX) {
static::$lastID = 1;
}

return $next;
return static::$lastID;
}
}
2 changes: 1 addition & 1 deletion tests/Fixtures/CommandResetter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

class CommandResetter extends Request
{
public static function reset()
public static function reset(): void
{
self::$lastID = 9000;
}
Expand Down
Loading