Workflow Pause #3114
Draft
Workflow Pause #3114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| id: 'workflow-pause-success-toast', | ||
| message: translate('workflows.pause-success'), | ||
| }); | ||
| } catch (err: unknown) { |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| $refresh = Date.now(); | ||
| triggerRefresh(Action.Reset); | ||
| hideResetModal(); | ||
| } catch (err) { |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| ) => { | ||
| if (refresh && !pause && $workflowRun?.workflow?.isRunning) { | ||
| const shouldFetch = | ||
| refresh.timestamp && |
Contributor
There was a problem hiding this comment.
⚠️ 'refresh.action' is possibly 'null'.
| response.workflowExecutionInfo.status, | ||
| ); | ||
| const isRunning = status === 'Running'; | ||
| const isPaused = status === 'Paused'; |
Contributor
There was a problem hiding this comment.
⚠️ 'response' is possibly 'undefined'.⚠️ 'response.workflowExecutionInfo' is possibly 'undefined'.
| ); | ||
| const isRunning = status === 'Running'; | ||
| const isPaused = status === 'Paused'; | ||
| const historyEvents = response.workflowExecutionInfo.historyLength; |
Contributor
There was a problem hiding this comment.
⚠️ 'response' is possibly 'undefined'.⚠️ 'response.workflowExecutionInfo' is possibly 'undefined'.
| parent, | ||
| stateTransitionCount, | ||
| isRunning, | ||
| isPaused, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'Duration | undefined' is not assignable to type 'Duration'.
laurakwhit
force-pushed
the
workflow-pause
branch
from
fdf8e6c to
1d394d2
Compare
| @@ -127,6 +137,7 @@ | |||
| <div class="xl:hidden"> | |||
| <WorkflowActions | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'boolean | undefined' is not assignable to type 'boolean'.
| @@ -127,6 +137,7 @@ | |||
| <div class="xl:hidden"> | |||
| <WorkflowActions | |||
| {isRunning} | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'boolean | undefined' is not assignable to type 'boolean'.
| <WorkflowActions | ||
| {isRunning} | ||
| {isPaused} | ||
| {cancelInProgress} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
| @@ -154,6 +165,7 @@ | |||
| <div class="max-xl:hidden"> | |||
| <WorkflowActions | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'boolean | undefined' is not assignable to type 'boolean'.
| @@ -154,6 +165,7 @@ | |||
| <div class="max-xl:hidden"> | |||
| <WorkflowActions | |||
| {isRunning} | |||
Contributor
There was a problem hiding this comment.
⚠️ Type 'boolean | undefined' is not assignable to type 'boolean'.
| <WorkflowActions | ||
| {isRunning} | ||
| {isPaused} | ||
| {cancelInProgress} |
Contributor
There was a problem hiding this comment.
⚠️ Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
| unhandledAction(action); | ||
| } | ||
|
|
||
| return translate('workflows.workflow-action-reason-placeholder', { |
Contributor
There was a problem hiding this comment.
⚠️ Variable 'translatedAction' is used before being assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Run temporal server from a local build
truemake binsandmake starttemporal operator namespace create --namespace canarycanarynamespace, runtemporal operator search-attribute create --namespace default --name CustomKeywordField --type KeywordRun the UI against a local build of temporal server
workflow-pausebranch in the UI repocd server/ && make buildcd .. && pnpm dev:local-temporalRun some sample workflows in the canary-go repo
make binsand./temporal-canary startWith
namespaceInfo>capabilities>workflowPausedisabled > go to aRunningworkflowPause Workflowis not visibleWith
namespaceInfo>capabilities>workflowPauseenabled > go to aRunningworkflowPause Workflowis not visiblePause Workflowis not visiblePause Workflow> enter a reason and confirmPausedand button switches toUnpause WorkflowSelect
Unpause Workflow> enter a reason and confirmChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-3566Docs
Any docs updates needed?