Skip to content

Conversation

@andrewzamojc
Copy link
Contributor

@andrewzamojc andrewzamojc commented Jan 26, 2026

Description & motivation 💭

This PR improves the UX of the timezone popover. I attempts to consolidate the option for the user and give a better scrolling experience.

  • previously the popover scrolled all content, now only the timezone menu items scroll
  • relative is now "just another format"
  • timezone does not lose/reset, even when switching to formats that don't use timezone (relative, iso)
  • 12/24 hour option is disabled for relative and iso formats
  • timezone menu items are disabled for relative and iso formats
  • auto scroll to selected item when the popover opens

also

  • minor improvemtn to workflows page heading, so refresh button doesn't push to the right

Screenshots (if applicable) 📸

BEFORE
Screenshot 2026-01-26 at 4 44 49 PM
AFTER
Screenshot 2026-01-26 at 4 30 04 PM

BEFORE
Screenshot 2026-01-26 at 4 33 24 PM
AFTER
Screenshot 2026-01-26 at 4 43 52 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
holocene Ready Ready Preview, Comment Jan 27, 2026 6:59pm

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Jan 26, 2026

Warnings
⚠️

📊 Strict Mode: 2 errors in 2 files (0.2% of 1120 total)

src/lib/utilities/format-date.ts (1)
  • L157:3: Function lacks ending return statement and return type does not include 'undefined'.
src/lib/pages/workflows-with-new-search.svelte (1)
  • L90:4: Type 'string | null' is not assignable to type 'string'.

Generated by 🚫 dangerJS against 3194ac5

@andrewzamojc
Copy link
Contributor Author

Hey @bilal-karim . What do you think of these updates to the timezone popover?

@bilal-karim
Copy link
Member

@andrewzamojc Looks much better. Is there a reason we're adding System, in addition 12h/24h for the hour format?

@andrewzamojc
Copy link
Contributor Author

@bilal-karim The browser has a default 12/24 hour option, so choosing system mean staying in sync with your computer's setting. Sort of like how we have system for light/dark mode. Let me know if you'd like a change.

@bilal-karim
Copy link
Member

@andrewzamojc I don't mind it. I'm just thinking if we should just use the label instead of the icon to be consistent with 12h and 24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants