-
Notifications
You must be signed in to change notification settings - Fork 128
[DT-3501] ux updates to timezone popover #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Hey @bilal-karim . What do you think of these updates to the timezone popover? |
|
@andrewzamojc Looks much better. Is there a reason we're adding System, in addition 12h/24h for the hour format? |
|
@bilal-karim The browser has a default 12/24 hour option, so choosing system mean staying in sync with your computer's setting. Sort of like how we have system for light/dark mode. Let me know if you'd like a change. |
|
@andrewzamojc I don't mind it. I'm just thinking if we should just use the label instead of the icon to be consistent with 12h and 24. |
Description & motivation 💭
This PR improves the UX of the timezone popover. I attempts to consolidate the option for the user and give a better scrolling experience.
also
Screenshots (if applicable) 📸
BEFORE


AFTER
BEFORE


AFTER
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?