Fix XWayland GLX crash when opening child dialogs (#1233)#1259
Merged
Conversation
Auto-detect Wayland sessions and prefer native Wayland platform to avoid XWayland GLX context-switching BadAccess crashes. Add AETHER_NO_GPU env var for runtime software-rendering fallback. Fix PII-redaction regex objects to survive crash teardown (heap-allocate to avoid static destruction order issues). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the intentional-leak raw `new QRegularExpression` pattern with a Q_GLOBAL_STATIC<PiiPatterns> struct. The global static is lazily initialised once and its isDestroyed() guard short-circuits redactPii() if called during crash teardown — same correctness guarantee, no raw heap leak. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit f10ecec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1233
Generated by AetherClaude (automated agent for AetherSDR)