Skip to content

fix: retry mumble client on socket errors#600

Open
garrappachc wants to merge 6 commits into
masterfrom
codex/add-mumble-reconnect-retries
Open

fix: retry mumble client on socket errors#600
garrappachc wants to merge 6 commits into
masterfrom
codex/add-mumble-reconnect-retries

Conversation

@garrappachc
Copy link
Copy Markdown
Member

No description provided.

@garrappachc garrappachc self-assigned this May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Playwright test results

passed  198 passed
flaky  1 flaky

Details

stats  199 tests across 29 suites
duration  8 minutes, 10 seconds
commit  71adb33

Flaky tests

chromium › 10-queue/10-chat.spec.ts › admin can delete a chat message @6v6 @9v9

@garrappachc garrappachc force-pushed the codex/add-mumble-reconnect-retries branch from 3a50647 to 6ebac9e Compare May 22, 2026 16:02
garrappachc and others added 5 commits May 22, 2026 18:06
Eliminates two related issues:
- afterConnect/moveToTargetChannel used the module-level `client` variable
  which could be stale if tryConnect() was called again during a retry
- reconnecting flag was released before localClient.connect(), opening a
  window for parallel concurrent retry attempts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant