Updating to 9.1 and a few other features#3
Open
tescalada wants to merge 7 commits into
Open
Conversation
just cleaning up some typos
The sks keyserver is deprecated. Switched to keyserver.ubuntu.com and that seems to have fixed the issue.
bumping up to the latest version.
This will enable setting a .env file with IMAGE=username/pdi in it to override the image name in both the spoon script and the makefile. When building or running in the makefile it will use the custom image name and when using the spoon script it will use the custom image name. This way any forks from here out can set a .env file with their own repo name instead of needing to hardcode their own username into the code. It should also allow for CI scripts to build and publish containers a bit more easily. This patch does not change the default behavior of the makefile or spoon script, however the makefile's default image name is pdi, and the spoon scripts default image name is tgmti/pdi. This should maybe be standardized to the same default value at some point.
docker-compose is no longer a requirement of the project
This will allow you to encrypt a password using the encr.sh script
This allows building of custom dockerfiles that extend the main image without needing to fork the repo. The DOCKERFILE name can be set in the .env file so that you can just run make setup to build your custom image. The reason to build a custom image is to include custom plugins in the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to version 9.1
fixes several typos in the code/docs
exposes a command to obfuscate passwords
introduces a .env file for managing custom dockerfiles/tags without needing to update the coded repo username
fixes a build issue with broken keyservers.