refactor(notifications): migrate ws auth to first-message pattern, ad…#42
Merged
refactor(notifications): migrate ws auth to first-message pattern, ad…#42
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tdn-client | e32e064 | Commit Preview URL Branch Preview URL |
May 07 2026, 04:06 PM |
aquie00t
force-pushed
the
refactor/ws-auth-first-message
branch
4 times, most recently
from
6d277d5 to
151f5df
Compare
…d max retries with toast
- Remove token from WebSocket URL query param (security: token no longer
logged in browser console or server access logs)
- Send { event: 'auth', token } as first message on ws.onopen
- Add MAX_RETRIES = 5 to stop infinite reconnect loop
- Show info toast after max retries are exhausted
Relates to: the-developer-network/tdn-api#121
aquie00t
force-pushed
the
refactor/ws-auth-first-message
branch
from
151f5df to
e32e064
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d max retries with toast
Relates to: the-developer-network/tdn-api#121
Summary
Type of change
How was this tested?
Screenshots (if applicable)
Checklist
pnpm lintpassespnpm exec tsc -bpasses (no type errors)anytypes introducedconsole.logleft in code