refactor(sync-engine): replace unsafe any type with generic parameter in SyncJob payload (#36)#39
Open
rohansaini-02 wants to merge 1 commit into
Conversation
… in SyncJob payload (theapprenticeproject#36)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the unsafe
anytype with a generic parameterT(defaulting tounknown) inSyncJobandSyncQueuewithin thepoc-sync-enginepackage to guarantee compile-time type safety.Related Issue
Resolves #36
Changes Made
SyncJob<T = unknown>andSyncQueue<T = unknown>to replace the unsafepayload: anytyping.SyncManager<T = unknown>and its helper methods to correctly use and forward the typed generic payload.SyncManager.test.tsthat instantiates a typedSyncQueuewith a custom payload interface and validates that types are preserved upon retrieval.Testing Performed
poc-sync-engine:npm test