feat(frappe-api): implement StorageAuthService for persistent credentials storage (#38)#40
Open
rohansaini-02 wants to merge 1 commit into
Conversation
fabc212 to
6d09934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
StorageAuthServiceinpoc-frappe-apito persist authentication credentials using an injected storage provider interface, ensuring users stay logged in across application restarts.Related Issue
Resolves #38
Changes Made
IStorageProviderinterface with support for both synchronous and asynchronous operations (getItem,setItem,removeItem).StorageAuthServiceto serialize credentials to and from the storage provider under a custom key.null) when the storage is empty, fields are missing, or serialization payload is corrupted.AuthService.test.tstesting the persistent storage implementation against both synchronous and asynchronous mock providers.Testing Performed
poc-frappe-api:npm testAuthService.test.tsandFrappeClient.test.tspassed successfully.