feat(sync-engine): introduce pluggable SyncHandler interface in SyncManager (#37)#44
Open
rohansaini-02 wants to merge 1 commit into
Conversation
|
Hey, did you get any update? |
Author
Not yet, most orgs have already notified their selected contributors, but there’s no update on the TAP projects yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a pluggable
SyncHandlerinterface inSyncManagerwithin thepoc-sync-enginepackage. This decouples queue orchestration from the mock API transport, allowing interchangeable mock or HTTP-backed execution handlers.Related Issue
Resolves #37
Changes Made
SyncHandlerinterface with ahandle(job: SyncJob)signature.SyncHandlerdependency and updateddrainQueue()to delegate sync processing to it.mockFrappeApiCallprivate helper method.jest.useFakeTimers()) to verify that connection rejections trigger exponential retry backoffs correctly.Testing Performed
poc-sync-engine:npm test