chore(deps): bump symphonia from 0.5.5 to 0.6.0 in /src-tauri#6
chore(deps): bump symphonia from 0.5.5 to 0.6.0 in /src-tauri#6dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [symphonia](https://github.com/pdeljanov/Symphonia) from 0.5.5 to 0.6.0. - [Release notes](https://github.com/pdeljanov/Symphonia/releases) - [Commits](pdeljanov/Symphonia@v0.5.5...v0.6.0) --- updated-dependencies: - dependency-name: symphonia dependency-version: 0.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummaryThis PR is an automated dependabot bump of symphonia from 0.5.5 to 0.6.0, updating
Confidence Score: 1/5Not safe to merge — the version bump breaks compilation of the audio decode module. Symphonia 0.6.0 changed two APIs used directly in decode.rs: next_packet() now returns Result<Option> instead of Result, and CodecParameters became a typed enum whose fields are no longer directly accessible. Neither change is handled in the source, so the project will not compile after this bump. src-tauri/src/audio/decode.rs needs to be updated alongside this bump to handle the new next_packet() return type and the CodecParameters enum restructuring. Important Files Changed
Sequence DiagramsequenceDiagram
participant App
participant FormatReader
participant Decoder
Note over App,Decoder: symphonia 0.5.5 behaviour expected by decode.rs
App->>FormatReader: next_packet()
FormatReader-->>App: "Ok(Packet)"
App->>Decoder: decode(packet)
Decoder-->>App: AudioBufferRef
FormatReader-->>App: "Err(IoError UnexpectedEof) break"
Note over App,Decoder: symphonia 0.6.0 actual behaviour compile error
App->>FormatReader: next_packet()
FormatReader-->>App: "Ok(Some(Packet)) or Ok(None) on EOF"
App->>App: "Ok(packet) binds Option track_id() fails to compile"
Reviews (1): Last reviewed commit: "chore(deps): bump symphonia from 0.5.5 t..." | Re-trigger Greptile |
|
Looks like symphonia is up-to-date now, so this is no longer needed. |
Bumps symphonia from 0.5.5 to 0.6.0.
Release notes
Sourced from symphonia's releases.
... (truncated)
Commits
980bf58chore: Release v0.6.0.2a2e1c6isomp4: Prevent some panic cases.4165bb0mpa: Accept a Xing LAME tag with a CRC of 0.f7a3680isomp4: Populate number of frames if track timescale == sample rate.ad5f2d7isomp4: Support media information and better EOS detection.79de36bisomp4, adpcm: Fix some crashes. (#497)124aaf4chore: Misc. README updates.83cfad8alac: Populate missing codec parameter fields from magic cookie.8304e2acore (formats): Ignore metadata reader errors for trailing metadata.7529deemkv: Reduce the Timebase.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)