Add delete ISO method for vmware#181
Merged
stejskalleos merged 1 commit intotheforeman:masterfrom Mar 20, 2026
Merged
Conversation
Contributor
Author
sbernhard
force-pushed
the
delete_iso
branch
2 times, most recently
from
4b3f820 to
c8306f9
Compare
Draft
Contributor
Author
|
Mark as Draft because it needs fog/fog-vsphere#316 |
|
I have seen this in action and it works. Code also looks good to me 👍 |
|
Does this require some changes in the documentation? If so, please let the docs team know. |
nadjaheitmann
approved these changes
Mar 18, 2026
Contributor
Author
Had a look in the documentation and it is not written, that e.g. user need to remove the ISO etc. So, I would say, no documentation change necessary. |
stejskalleos
approved these changes
Mar 20, 2026
Collaborator
stejskalleos
left a comment
stejskalleos
left a comment
There was a problem hiding this comment.
🍏 Code LGTM,
I haven't tested it personally, but we have ACK from @nadjaheitmann , so let's get this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: fog/fog-vsphere#316