Use dashes in HTTP header names in SSL vhost config#492
Merged
ehelms merged 1 commit intotheforeman:masterfrom May 7, 2026
Merged
Use dashes in HTTP header names in SSL vhost config#492ehelms merged 1 commit intotheforeman:masterfrom
ehelms merged 1 commit intotheforeman:masterfrom
Conversation
evgeni
approved these changes
May 6, 2026
Some backends reject headers with underscores before converting dashes to underscores for application processing. Use dashes in RequestHeader names to match the HTTP vhost and ensure headers pass through the full proxy chain. Add a test to catch underscore usage in httpd config headers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Some backends reject headers with underscores before converting dashes to underscores for application processing. Use dashes in RequestHeader names to match the HTTP vhost and ensure headers pass through the full proxy chain.
Ref: theforeman/puppet-foreman@d92fea4
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
./foremanctl deployChecklist