🐛 wrap non-Error causes passed to Err()#1165
Closed
rauhryan wants to merge 1 commit intothefrontside:v4from
Closed
🐛 wrap non-Error causes passed to Err()#1165rauhryan wants to merge 1 commit intothefrontside:v4from
rauhryan wants to merge 1 commit intothefrontside:v4from
Conversation
Member
|
This has been superseded by #1149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Err()currently acceptsError, but JavaScriptcatchblocks and promise rejections can produceunknownthrown values. That makes it awkward to pass caught values directly toErr()and can leak non-Errorthrow values through APIs that model failures asError.This splits the
Err()behavior change out so it can target the same base branch as #1149.Approach
Err()to acceptunknownErrorinstances as-isErrorcauses inThrowValueError(String(cause), { cause })as Errorcasts where caught values are passed toErr()Err()anduntil(Promise.reject(...))