Inspect Exec Connections#48
Draft
chrizzFTD wants to merge 7 commits into
Draft
Conversation
Collaborator
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2a3509e. Configure here.
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
6af2f4a to
452e454
Compare
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
Signed-off-by: Christian López Barrón <chris.gfz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow inspection of exec networks through the ConnectionViewer
Note
Medium Risk
Touches shared connection-graph code used for UsdShade and new attribute traversal; wrong routing or port IDs could break graph layout or misrepresent rig wiring, though existing shade tests remain and exec coverage is additive.
Overview
Extends the Connections Viewer so rigs and other prims wired through
UsdAttributeconnection paths (not onlyUsdShadeConnectableAPI) show an upstream authored graph—covering OpenExec invertible rigs (IrJointScope,IrFkController,IrSwitchController, etc.)._graph_from_connectionsnow picks shade vs attribute traversal. Attribute mode walksGetConnections(), builds Graphviz nodes with schema type in the header, mapsirRoleto port colors (inputs, outputs, switches, passthrough), and sanitizes port IDs when names contain:(e.g.posed:space→posed__space). UsdShade graph building shares the same table/port helpers.Docs for the Connections Viewer describe the dual traversal model, port legend, and that the view is the authored stage graph, not the compiled OpenExec eval network. Adds
waddlerRig.usdaandtest_exec_connection_viewto lock in Switch/FK wiring from a joint prim.Reviewed by Cursor Bugbot for commit 2a3509e. Bugbot is set up for automated code reviews on this repo. Configure here.