Update similarity.py to improve test coverage to 94%#295
Open
mohini-aggarwal wants to merge 1 commit intotheochem:mainfrom
Open
Update similarity.py to improve test coverage to 94%#295mohini-aggarwal wants to merge 1 commit intotheochem:mainfrom
mohini-aggarwal wants to merge 1 commit intotheochem:mainfrom
Conversation
mohini-aggarwal
commented
Apr 3, 2026
mohini-aggarwal
commented
- Updated selector/measures/similarity.py to the 94% coverage version.
- Added comprehensive tests in test_diversity_comprehensive.py.
- Ready for review and integration into main repository.
Author
|
Hi Mentors @FarnazH @FanwangM @marco-2023 ! I submitted this PR (#295 ) improving test coverage in Thank you for your guidance! |
FanwangM
requested changes
Apr 8, 2026
Collaborator
FanwangM
left a comment
FanwangM
left a comment
There was a problem hiding this comment.
Thanks for the PR. The current PR adds an empty line after each docstring/code block, which should be avoided. This also makes the code unreadable. Please fix this and we will do further code review. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.