zephyr: userspace_helper: add test_mailbox.c (plus a test) #10477
+183
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper function to make memory regions needed for sof/mailbox.h available to a user thread. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Add a user-space test for sof/mailbox.h interface usage. The test covers current usage of mailbox by SOF audio pipeline code. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
abonislawski,
dbaluta,
iuliana-prodan and
lyakh
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds support for accessing the SOF mailbox interface from Zephyr user-space threads by introducing a helper function and comprehensive test coverage.
Changes:
- Added
user_access_to_mailbox()helper function to grant user threads access to mailbox memory regions - Created test suite
test_mailbox.cto verify mailbox operations from both kernel and user contexts - Updated build configuration to include the new test when userspace is enabled
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| zephyr/test/userspace/test_mailbox.c | New test file implementing mailbox access tests from user-space threads |
| zephyr/test/userspace/README.md | Documentation update describing the new mailbox test |
| zephyr/test/CMakeLists.txt | Build configuration to compile test_mailbox.c when conditions are met |
| zephyr/lib/userspace_helper.c | Implementation of user_access_to_mailbox() for memory domain setup |
| zephyr/include/rtos/userspace_helper.h | Header declaration for the new helper function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| struct sof_ipc_stream_posn posn; | ||
| size_t offset = 0; /* first stream position slot */ | ||
|
|
||
| LOG_INF("Write to IPC4 stream#0 position info offset %u size %u.", |
There was a problem hiding this comment.
The log message incorrectly states 'IPC4' when this code path is for non-IPC4 configurations (inside #else block for CONFIG_IPC_MAJOR_4). Should reference the appropriate IPC version or use generic terminology.
Suggested change
| LOG_INF("Write to IPC4 stream#0 position info offset %u size %u.", | |
| LOG_INF("Write to stream#0 position info offset %u size %zu.", |
lgirdwood
approved these changes
Jan 9, 2026
| void module_driver_heap_remove(struct k_heap *mod_drv_heap) | ||
| { } | ||
|
|
||
| int user_access_to_mailbox(struct k_mem_domain *domain, k_tid_t thread_id) |
Member
There was a problem hiding this comment.
nitpick: we can make this static inline in the header and it would save a little TEXT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper function to make memory regions needed for sof/mailbox.h
available to a user thread.