Skip to content

fix: handle UID 0 (root user) case in docker-entrypoint.sh #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lroolle merged 8 commits into from
Jun 23, 2025
Merged

fix: handle UID 0 (root user) case in docker-entrypoint.sh #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3134632
fix: handle UID 0 (root user) case in docker-entrypoint.sh
claude[bot] Jun 23, 2025
e9e14e0
fix: handle UID=0 and GID=0 independently for security
lroolle Jun 23, 2025
232b0ea
fix: add explicit github_token to claude-code-review action
lroolle Jun 23, 2025
35db5ef
docs: add OIDC token fix to dev log
lroolle Jun 23, 2025
c0e985f
refactor: remove redundant comments in UID/GID handling
lroolle Jun 23, 2025
21a2739
feat: dynamic fallback UID/GID selection for root users
lroolle Jun 23, 2025
4dfc33d
simplify: revert to hardcoded 1000 fallback for root users
lroolle Jun 23, 2025
088402f
docs: clarify root cause and solution for UID 0 handling
lroolle Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
uses: anthropics/claude-code-action@beta
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
github_token: ${{ secrets.GITHUB_TOKEN }}

# Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
# model: "claude-opus-4-20250514"
Expand Down
30 changes: 30 additions & 0 deletions DEV-LOGS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,36 @@

## Issue Analysis: 2025-06-23

### [bug-fixed] Root user (UID 0) handling in docker-entrypoint.sh

**Problem**: `sudo claude-yolo` fails with "usermod: UID '0' already exists" error.

**Root Cause**: Can't reassign existing UID 0 (root) to claude user.

**Security Fix**: Handle UID=0 and GID=0 independently to prevent root group assignment.

**Solution**: Use fallback UID/GID 1000 for proper file ownership with existing collision handling.

**Status**: ✅ **COMPLETED** - PR #22

---

## Issue Analysis: 2025-06-23

### [bug-fixed] Claude Code Review OIDC token authentication error

**Problem**: CI failing with "Invalid OIDC token" after changing permissions to write.

**Solution**: Added explicit `github_token: ${{ secrets.GITHUB_TOKEN }}` to force direct token auth.

**Cause**: Write permissions trigger GitHub App auth by default, but no App configured.

**Status**: ✅ **COMPLETED**

---

## Issue Analysis: 2025-06-23

### [enhancement-completed] Claude Code Review workflow simplification

**Problem**: Overcomplicated workflow with manual duplicate detection using GitHub CLI.
Expand Down
10 changes: 10 additions & 0 deletions docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ setup_nonroot_user() {
local current_uid=$(id -u "$CLAUDE_USER")
local current_gid=$(id -g "$CLAUDE_USER")

if [ "$CLAUDE_UID" = "0" ]; then
echo "[entrypoint] WARNING: Host user is root (UID=0). Using fallback UID 1000 for security."
CLAUDE_UID=1000
fi

if [ "$CLAUDE_GID" = "0" ]; then
echo "[entrypoint] WARNING: Host user is in root group (GID=0). Using fallback GID 1000 for security."
CLAUDE_GID=1000
fi

if [ "$CLAUDE_GID" != "$current_gid" ]; then
[ "$VERBOSE" = "true" ] && echo "[entrypoint] updating $CLAUDE_USER GID: $current_gid -> $CLAUDE_GID"
if getent group "$CLAUDE_GID" >/dev/null 2>&1; then
Expand Down
Loading