Skip to content

Create bindings for Vega and Vega-Lite#13

Merged
thheller merged 1 commit intothheller:masterfrom
teodorlu:master
May 14, 2019
Merged

Create bindings for Vega and Vega-Lite#13
thheller merged 1 commit intothheller:masterfrom
teodorlu:master

Conversation

@teodorlu
Copy link
Copy Markdown
Contributor

Basis for this PR is an attempt to use Shadow-CLJSJS to build a project that makes use of Oz. Oz uses Vega and Vega Lite for visualization. For more details, see the issue. Credit for this work is to @ivanminutillo.

@thheller, does this look right to you? I don't have a lot of Clojurescript experience, and I'd be happy to get a second pair of eyes.

@thheller
Copy link
Copy Markdown
Owner

Looks good to me. Assuming this actually works?

@thheller thheller merged commit 86ac3d0 into thheller:master May 14, 2019
@teodorlu
Copy link
Copy Markdown
Contributor Author

teodorlu commented May 15, 2019

It works when I put the files directly on the classpath (example). I haven't tested running Shadow-CLJS with a version of shadow-cljsjs that includes these changes.

I hope to be able to remove the cljs/{vega,vega_embed,vega_lite,vega_tooltip}.cljs files when these changes reach Shadow-CLJS. I assume that happens when you've bumped the versions of shadow-cljsjs and shadow-cljs?

@thheller
Copy link
Copy Markdown
Owner

I already released [thheller/shadow-cljsjs "0.0.18"] so you can bump that. I'll make a new shadow-cljs release soon that'll include that dep.

@teodorlu
Copy link
Copy Markdown
Contributor Author

Sounds great! I'll test now.

@teodorlu
Copy link
Copy Markdown
Contributor Author

teodorlu commented May 15, 2019

Works like a charm! See diff for the example project.

@jamiepratt
Copy link
Copy Markdown

I think the correct symbol name to export from vega-lite is vegaLite not vl. Hanami is trying to call vegaLite.

#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants