Skip to content

[pull] develop from frappe:develop #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 4 commits into from
Jun 2, 2026
Merged

[pull] develop from frappe:develop #346

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3769f7e
test: update loan repayment party assertion for payroll payable GL entry
Nihantra-Patel Jun 2, 2026
1cc8490
test: update loan repayment party assertion for payroll payable GL entry
Nihantra-Patel Jun 2, 2026
b90d642
fix: set party_not_required flag for loan repayment GL entries when e…
Nihantra-Patel Jun 2, 2026
22acbcf
Merge pull request #4630 from Nihantra-Patel/update_lending_testcase
deepeshgarg007 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hrms/payroll/doctype/salary_slip/salary_slip_loan_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,12 @@ def make_loan_repayment_entry(doc: "SalarySlip"):
)

repayment_entry.save()

if not process_payroll_accounting_entry_based_on_employee:
frappe.flags.party_not_required = True

repayment_entry.submit()
frappe.flags.party_not_required = False

frappe.db.set_value("Salary Slip Loan", loan.name, "loan_repayment_entry", repayment_entry.name)

Expand Down
Loading