Skip to content

fix(security): harden Puma against HTTP Request Smuggling (CVE) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AjayPAnand wants to merge 1 commit into
base: 10.0.x
Choose a base branch
from
Open

fix(security): harden Puma against HTTP Request Smuggling (CVE) #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ end
gem 'mysql2'

# Webserver - included in development and test and optionally in production
gem 'puma'
gem 'puma', '>= 6.4.3'

gem 'bootsnap', require: false
gem 'csv'
Expand Down
10 changes: 10 additions & 0 deletions config/puma.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@
#
# workers ENV.fetch("WEB_CONCURRENCY") { 2 }

workers ENV.fetch("WEB_CONCURRENCY", 2)
threads_count = ENV.fetch("RAILS_MAX_THREADS", 5)
threads threads_count, threads_count
preload_app!
port ENV.fetch("PORT", 3000)
environment ENV.fetch("RAILS_ENV", "development")

# SECURITY FIX: Raise on SIGTERM to prevent request queue poisoning
raise_exception_on_sigterm

# Use the `preload_app!` method when specifying a `workers` number.
# This directive tells Puma to first boot the application and load code
# before forking the application. This takes advantage of Copy On Write
Expand Down