Skip to content

feat: addition of a button below existing one for the routing to the …#455

Open
owens-hub-git wants to merge 2 commits intothoth-tech:Feature/Cross-Unitfrom
owens-hub-git:10.0.x
Open

feat: addition of a button below existing one for the routing to the …#455
owens-hub-git wants to merge 2 commits intothoth-tech:Feature/Cross-Unitfrom
owens-hub-git:10.0.x

Conversation

@owens-hub-git
Copy link
Copy Markdown

@owens-hub-git owens-hub-git commented Apr 5, 2026

Description

Strict frontend change in the home component where I added a button underneath the current view all for previous units. This still routes to the same component for previous units, but will be the start for the cross-unit dashboard development

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Run the project locally.
  2. Opened the HomePage as a student
  3. Changing layouting for responsiveness and routing
  4. npm test locally

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

Copy link
Copy Markdown

@cillynder cillynder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard button should be above the history button as it would generally be more important.

color="primary"
mat-fab
extended
aria-label="view all projects"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aria-label="view all projects"
aria-label="view previous projects"

extended
aria-label="view all projects"
>
<mat-icon style="color: white">history</mat-icon> View all
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<mat-icon style="color: white">history</mat-icon> View all
<mat-icon style="color: white">history</mat-icon> View previous

Should be changed so it's distinct from the other button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants