Conversation
|
I'm not sure how this will identify the client? In our usual setup the client of Flair is running on the same machine as it. |
Yeah actually you're right it's going to be noisy. We probably don't need the logs on reads, only on Execute, since Reads can come from the workers; this should lower the noise. |
|
Actually I'm wondering if we could collect those as metrics instead of logs. That would be much more useful and wouldn't pollute the logs. |
|
Let's have a think about what we want to know. Maybe something like:
I think we may want to make flair use structured logging so we can record metadata against these loglines that we can analyse in logstash too. |
This PR adds some debug logs to flair, so it's easier for us to see which client the load is coming from.